feat: implement Infra layer for favorite heritages list (WorldHeritageQueryService) / お気に入り一覧のInfra層実装（WorldHeritageQueryService） - #569
Closed
zigzagdev wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/user-favorite #569 +/- ##
========================================================
+ Coverage 63.70% 63.89% +0.19%
- Complexity 1657 1666 +9
========================================================
Files 142 143 +1
Lines 8607 8656 +49
========================================================
+ Hits 5483 5531 +48
- Misses 3124 3125 +1
🚀 New features to boost your workflow:
|
Owner
Author
|
Infra layer is already merged (#564); this work is being consolidated into a single Application-layer commit instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 目的
Following #564 (
FavoriteRepository::getFavoriteWorldHeritageIds), add the remaining Infra-level piece needed for the favorites list: given a list of world heritage ids, return them as aWorldHeritageDtoCollectionso the Application layer doesn't need to duplicate the existing payload-building logic (buildWorldHeritagePayload+WorldHeritageDtoCollectionFactory) already used bygetAllHeritages()/searchHeritages().Pagination is intentionally out of scope here — it will be added later once needed;
getHeritagesByIds()just returns the full collection for the ids it's given.What I have done / 実施内容
WorldHeritageQueryServiceInterface::getHeritagesByIds(array $ids): WorldHeritageDtoCollectionWorldHeritageQueryService, reusing the samefindByIdsPreserveOrder()+buildWorldHeritagePayload()+buildDtoFromCollection()pipeline assearchHeritages()DatabaseSeeder)Test Results / テスト結果
Full suite: 197 passed.